Change the check for the existence of cryptsetup command#8480
Closed
lucas-a-martins wants to merge 14 commits intoapache:mainfrom
Closed
Change the check for the existence of cryptsetup command#8480lucas-a-martins wants to merge 14 commits intoapache:mainfrom
cryptsetup command#8480lucas-a-martins wants to merge 14 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when starting the Agent, ACS checks if the
cryptsetupcommand can be used by using the command'shelp; the output of the command is printed in the logs. However, this output is too verbose and can be confusing.This PR addresses this issue by using the utility version to check the command, instead of
help, which is much less verbose.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
I checked the logs before and after changes. As shown in the screenshots above, the logs became more intuitive.